Bug 146648 - Remove unused "m_isPrivate" flag on NetworkStorageSession
Summary: Remove unused "m_isPrivate" flag on NetworkStorageSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-06 11:38 PDT by Brady Eidson
Modified: 2015-07-06 12:46 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (3.66 KB, patch)
2015-07-06 11:39 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-07-06 11:38:09 PDT 
Remove unused "m_isPrivate" flag on NetworkStorageSession
Comment 1 Brady Eidson 2015-07-06 11:39:00 PDT 
Created attachment 256225 [details]
Patch v1
Comment 2 Alex Christensen 2015-07-06 11:40:32 PDT 
lgtm, but why is this now unused?
Comment 3 Brady Eidson 2015-07-06 11:55:24 PDT 
(In reply to comment #2)
> lgtm, but why is this now unused?

I don't know. I didn't search for the last time it was used. I just grepp'ed all of Source/ and found it's definitely unused now.

And all I know is that right now its existence is in my way. :)
Comment 4 WebKit Commit Bot 2015-07-06 12:46:28 PDT 
Comment on attachment 256225 [details]
Patch v1

Clearing flags on attachment: 256225

Committed r186369: <http://trac.webkit.org/changeset/186369>
Comment 5 WebKit Commit Bot 2015-07-06 12:46:32 PDT 
All reviewed patches have been landed.  Closing bug.