Bug 146642 - [Mac] Inactive AirPlay route should automatically timeout
Summary: [Mac] Inactive AirPlay route should automatically timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-06 09:32 PDT by Eric Carlson
Modified: 2015-07-06 11:06 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch. (12.63 KB, patch)
2015-07-06 10:19 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch. (12.63 KB, patch)
2015-07-06 10:55 PDT, Eric Carlson 		bfulgham: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-07-06 09:32:27 PDT 
Invalidate an AirPlay route when a media element has been paused for long enough.
Comment 1 Eric Carlson 2015-07-06 09:41:06 PDT 
<rdar://problem/21602955>
Comment 2 Eric Carlson 2015-07-06 10:19:08 PDT 
Created attachment 256218 [details]
Proposed patch.
Comment 3 WebKit Commit Bot 2015-07-06 10:22:04 PDT 
Attachment 256218 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:179:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2015-07-06 10:55:19 PDT 
Created attachment 256220 [details]
Updated patch.
Comment 5 Brent Fulgham 2015-07-06 10:59:32 PDT 
Comment on attachment 256220 [details]
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=256220&action=review

r=me. Please correct that indentation issue.

> Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:181
> +}

Whoops! This brace needs to be indented to match the "if" statement.
Comment 6 Eric Carlson 2015-07-06 11:06:23 PDT 
Committed r186361: https://trac.webkit.org/r186361