Bug 146640 – [CMake] Trigger the memory-reduction tricks on armhf too

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Emanuele Aina]

At the moment the --no-keep-memory compilation flag is only enabled for 32bit x86 processors, but would probably benefit every 32bit processor.

https://trac.webkit.org/browser/trunk/Source/cmake/OptionsCommon.cmake?rev=186354#L101

[Emanuele Aina]

Created attachment 256215 [details]
Patch

[Emanuele Aina]

I've tested the attached patch only with the armhf toolchain for the Raspberry Pi, so I've been conservative and simply added it to the match pattern.

A different option would be to try to detect if the current build architectures is 32bit using `getconf LONG_BIT` or something similar.

[Csaba Osztrogonác]

Comment on attachment 256215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256215&action=review

> ChangeLog:3
> +        [CMake] Trigger the memory-reduction tricks on armhf too

Just a nit: This line should be same as the title 
of the bug report. Please change one of them.

[WebKit Commit Bot]

Comment on attachment 256215 [details]
Patch

Rejecting attachment 256215 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 256215, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for '[e-mail]': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/135637

[WebKit Commit Bot]

Comment on attachment 256215 [details]
Patch

Clearing flags on attachment: 256215

Committed r189344: <http://trac.webkit.org/changeset/189344>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.