Bug 146625 - [WK2] Current page's scroll position is lost when transferring sessionState from one view to another
Summary: [WK2] Current page's scroll position is lost when transferring sessionState f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-05 19:56 PDT by Chris Dumez
Modified: 2015-07-05 23:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.52 KB, patch)
2015-07-05 20:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-07-05 19:56:36 PDT 
Current page's scroll position is lost when transferring sessionState from one view to another. This is because we only update the current WebBackForwardListItem after navigating away.
However, when the client swaps WebViews for navigating, we don't detect this as navigating away and the current WebBackForwardListItem is not updated with the current page's state (including the scroll position). This means that the information is not transferred via the sessionState and the scroll position (among other things) ends up being lost when navigating back in the new WebView.
Comment 1 Chris Dumez 2015-07-05 19:57:05 PDT 
rdar://problem/21585268
Comment 2 Chris Dumez 2015-07-05 20:10:08 PDT 
Created attachment 256186 [details]
Patch
Comment 3 WebKit Commit Bot 2015-07-05 20:11:41 PDT 
Attachment 256186 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebPage.cpp:300:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2015-07-05 23:33:06 PDT 
Comment on attachment 256186 [details]
Patch

Clearing flags on attachment: 256186

Committed r186304: <http://trac.webkit.org/changeset/186304>
Comment 5 WebKit Commit Bot 2015-07-05 23:33:13 PDT 
All reviewed patches have been landed.  Closing bug.