Bug 146613 - InlineCallFrames shouldn't be strongly marked by CodeBlock
Summary: InlineCallFrames shouldn't be strongly marked by CodeBlock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-04 12:26 PDT by Filip Pizlo
Modified: 2015-09-08 17:20 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.51 KB, patch)
2015-09-08 17:11 PDT, Geoffrey Garen 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-07-04 12:26:19 PDT 
In fact, they shouldn't be marked at all, because everything in them should already end up in the weak reference set in DFG::CommonData, since all of those references are FrozenValues in DFG IR.
Comment 1 Geoffrey Garen 2015-09-08 17:11:49 PDT 
Created attachment 260815 [details]
Patch
Comment 2 Saam Barati 2015-09-08 17:16:01 PDT 
Comment on attachment 260815 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2015-09-08 17:20:18 PDT 
Committed r189518: <http://trac.webkit.org/changeset/189518>