Bug 14661 - [s60] Some input format doesn't work properly
Summary: [s60] Some input format doesn't work properly
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: S60 Hardware S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-18 10:53 PDT by Rasvan Alexandrescu
Modified: 2008-04-09 11:39 PDT (History)
0 users

See Also:

Attachments
added style format functionality to text edit (7.26 KB, patch)
2007-07-18 11:07 PDT, Rasvan Alexandrescu 		zalan: review-
Details | Formatted Diff | Diff
modified as per comments (7.26 KB, patch)
2007-07-20 06:38 PDT, Rasvan Alexandrescu 		zalan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rasvan Alexandrescu 2007-07-18 10:53:45 PDT 
[s60] Some input format doesn't work properly.
Comment 1 Rasvan Alexandrescu 2007-07-18 11:07:37 PDT 
Created attachment 15563 [details]
added style format functionality to text edit
Comment 2 zalan 2007-07-19 13:47:11 PDT 
Comment on attachment 15563 [details]
added style format functionality to text edit 

the patch looks good. there is a tiny coding conventional issue in the following line
+    TBool aIsEmptyOk (!aInputRequired);

and actually, i'm not sure if this line is needed at all.
Comment 3 Rasvan Alexandrescu 2007-07-20 06:38:18 PDT 
Created attachment 15598 [details]
modified as per comments
Comment 4 zalan 2007-07-20 09:55:28 PDT 
Comment on attachment 15598 [details]
modified as per comments

r=me
Comment 5 zalan 2007-07-20 09:55:58 PDT 
r24482 -> ccb
Comment 6 Bradley Morrison 2008-04-09 11:39:24 PDT 
Bulk closing of all s60 platform bugs. 

Sorry for the noise!