Bug 146609 - Web Inspector: Exceptions in Network timeline when resource updates and filters are applied
Summary: Web Inspector: Exceptions in Network timeline when resource updates and filte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-04 08:18 PDT by Timothy Hatcher
Modified: 2015-07-06 00:15 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.44 KB, patch)
2015-07-04 08:27 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-07-04 08:18:07 PDT 
TimelineDataGrid._refreshDirtyDataGridNodes can trigger exceptions in DataGrid.removeChild and TreeOutline.removeChild if it is run while a filter is applied. We should just convert these exceptions to early returns.

These exceptions break the UI hard, where things won't be added anymore to the DataGrid.
Comment 1 Radar WebKit Bug Importer 2015-07-04 08:18:25 PDT 
<rdar://problem/21674514>
Comment 2 Timothy Hatcher 2015-07-04 08:27:01 PDT 
Created attachment 256147 [details]
Patch
Comment 3 Joseph Pecoraro 2015-07-05 22:37:28 PDT 
Comment on attachment 256147 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2015-07-06 00:14:48 PDT 
Comment on attachment 256147 [details]
Patch

Clearing flags on attachment: 256147

Committed r186306: <http://trac.webkit.org/changeset/186306>
Comment 5 WebKit Commit Bot 2015-07-06 00:15:00 PDT 
All reviewed patches have been landed.  Closing bug.