Bug 146607 - Web Inspector: Cached resources are missing startTime and size in Network timeline
Summary: Web Inspector: Cached resources are missing startTime and size in Network tim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-04 07:28 PDT by Timothy Hatcher
Modified: 2015-07-05 23:27 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.70 KB, patch)
2015-07-04 07:36 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-07-04 07:28:57 PDT 
Some cached resources are missing start time and transfer size info.
Comment 1 Radar WebKit Bug Importer 2015-07-04 07:29:13 PDT 
<rdar://problem/21674401>
Comment 2 Timothy Hatcher 2015-07-04 07:36:57 PDT 
Created attachment 256143 [details]
Patch
Comment 3 Joseph Pecoraro 2015-07-05 22:34:53 PDT 
Comment on attachment 256143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256143&action=review

r=me!

> Source/WebInspectorUI/ChangeLog:11
> +        * UserInterface/Controllers/FrameResourceManager.js:
> +        (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache): Pass elapsedTime in the right argument order.
> +        Add missing calls to Resource.increaseSize and Resource.increaseTransferSize.
> +        (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse): Pass elapsedTime in the right argument order.

Yikes. Good catch!

> Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:237
> +        var resource = this._addNewResourceToFrame(requestIdentifier, frameIdentifier, loaderIdentifier, cachedResourcePayload.url, cachedResourcePayload.type, "GET", null, null, elapsedTime, null, null, initiatorSourceCodeLocation);

I wonder if this could have been anything but GET.
Comment 4 WebKit Commit Bot 2015-07-05 23:27:08 PDT 
Comment on attachment 256143 [details]
Patch

Clearing flags on attachment: 256143

Committed r186303: <http://trac.webkit.org/changeset/186303>
Comment 5 WebKit Commit Bot 2015-07-05 23:27:17 PDT 
All reviewed patches have been landed.  Closing bug.