Bug 146607 – Web Inspector: Cached resources are missing startTime and size in Network timeline

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

Some cached resources are missing start time and transfer size info.

[Radar WebKit Bug Importer]

<rdar://problem/21674401>

[Timothy Hatcher]

Created attachment 256143 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 256143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256143&action=review

r=me!

> Source/WebInspectorUI/ChangeLog:11
> +        * UserInterface/Controllers/FrameResourceManager.js:
> +        (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache): Pass elapsedTime in the right argument order.
> +        Add missing calls to Resource.increaseSize and Resource.increaseTransferSize.
> +        (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse): Pass elapsedTime in the right argument order.

Yikes. Good catch!

> Source/WebInspectorUI/UserInterface/Controllers/FrameResourceManager.js:237
> +        var resource = this._addNewResourceToFrame(requestIdentifier, frameIdentifier, loaderIdentifier, cachedResourcePayload.url, cachedResourcePayload.type, "GET", null, null, elapsedTime, null, null, initiatorSourceCodeLocation);

I wonder if this could have been anything but GET.

[WebKit Commit Bot]

Comment on attachment 256143 [details]
Patch

Clearing flags on attachment: 256143

Committed r186303: <http://trac.webkit.org/changeset/186303>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.