WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
146600
[Win] Remove "!!" operators placed in front of RegisterClassEx() calls
https://bugs.webkit.org/show_bug.cgi?id=146600
Summary
[Win] Remove "!!" operators placed in front of RegisterClassEx() calls
Sungmann Cho
Reported
2015-07-03 17:09:29 PDT
SSIA
Attachments
Patch
(2.50 KB, patch)
2015-07-03 17:13 PDT
,
Sungmann Cho
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sungmann Cho
Comment 1
2015-07-03 17:13:31 PDT
Created
attachment 256124
[details]
Patch
Chris Dumez
Comment 2
2015-07-03 17:24:10 PDT
Comment on
attachment 256124
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=256124&action=review
> Source/WebKit/win/ChangeLog:3 > + [Win] Remove "!!" operators placed in front of RegisterClassEx() calls.
Why? Although the !! is not technically needed, it makes it clear / explicit that we are converting a return value that is not a boolean (ATOM) into a boolean.
Sungmann Cho
Comment 3
2015-07-03 17:36:41 PDT
Oops. You are right. Thank you for pointing that out! Close the issue.
Gyuyoung Kim
Comment 4
2015-07-04 03:52:17 PDT
Comment on
attachment 256124
[details]
Patch Clearing review / commit-queue requests.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug