Xcode 7 recommends enabling a few more compiler warnings.
Created attachment 256117 [details] Update settings and fix some warnings
Attachment 256117 [details] did not pass style-queue: ERROR: Source/WebCore/bridge/objc/WebScriptObjectProtocol.h:27: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 1 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 256117 [details] Update settings and fix some warnings View in context: https://bugs.webkit.org/attachment.cgi?id=256117&action=review > Source/WTF/Configurations/Base.xcconfig:-56 > -GCC_MODEL_TUNING[sdk=macosx*] = G5; End of an era.
I’ll need to fix the iOS JavaScriptCore build (probably just not enable -Wunreachable-code for the project) and the Mac TestWebKitAPI build.
Committed <http://trac.webkit.org/r186268>.
Seems to have broken JSC build: CompileC /Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/LowLevelInterpreter.o llint/LowLevelInterpreter.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler cd /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore export LANG=en_US.US-ASCII /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu++11 -stdlib=libc++ -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -O0 -fno-common -Werror -Wno-missing-field-initializers -Wmissing-prototypes -Wunreachable-code -Wnon-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wsign-compare -Wno-shorten-64-to-32 -Wnewline-eof -Wno-c++11-extensions -DHAVE_HEADER_DETECTION_H -DENABLE_3D_TRANSFORMS -DENABLE_AVF_CAPTIONS -DENABLE_ATTACHMENT_ELEMENT -DENABLE_CACHE_PARTITIONING -DENABLE_CANVAS_PATH -DENABLE_CHANNEL_MESSAGING -DENABLE_ES6_ARROWFUNCTION_SYNTAX -DENABLE_ES6_CLASS_SYNTAX -DENABLE_ES6_TEMPLATE_LITERAL_SYNTAX -DENABLE_CONTENT_FILTERING -DENABLE_CSS_ANIMATIONS_LEVEL_2 -DENABLE_CSS_BOX_DECORATION_BREAK -DENABLE_CSS_COMPOSITING -DENABLE_CSS_GRID_LAYOUT -DENABLE_CSS_REGIONS -DENABLE_CSS_SELECTORS_LEVEL4 -DENABLE_CSS_SHAPES -DENABLE_CURSOR_VISIBILITY -DENABLE_DASHBOARD_SUPPORT -DENABLE_DETAILS_ELEMENT -DENABLE_DOM4_EVENTS_CONSTRUCTOR -DENABLE_ENCRYPTED_MEDIA -DENABLE_ENCRYPTED_MEDIA_V2 -DENABLE_FILTERS_LEVEL_2 -DENABLE_FULLSCREEN_API -DENABLE_GAMEPAD -DENABLE_GEOLOCATION -DENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING -DENABLE_ICONDATABASE -DENABLE_SERVICE_CONTROLS -DENABLE_INDEXED_DATABASE -DENABLE_INDIE_UI -DENABLE_INPUT_TYPE_COLOR -DENABLE_INPUT_TYPE_COLOR_POPOVER -DENABLE_LEGACY_CSS_VENDOR_PREFIXES -DENABLE_LEGACY_NOTIFICATIONS -DENABLE_LEGACY_VENDOR_PREFIXES -DENABLE_LEGACY_WEB_AUDIO -DENABLE_MATHML -DENABLE_MEDIA_CONTROLS_SCRIPT -DENABLE_MEDIA_SOURCE -DENABLE_MEDIA_STREAM -DENABLE_METER_ELEMENT -DENABLE_MOUSE_CURSOR_SCALE -DENABLE_NAVIGATOR_HWCONCURRENCY -DENABLE_NOTIFICATIONS -DENABLE_PDFKIT_PLUGIN -DENABLE_PROMISES -DENABLE_PUBLIC_SUFFIX_LIST -DENABLE_REQUEST_ANIMATION_FRAME -DENABLE_REMOTE_INSPECTOR -DENABLE_RUBBER_BANDING -DENABLE_CSS_SCROLL_SNAP -DENABLE_SPEECH_SYNTHESIS -DENABLE_STREAMS_API -DENABLE_SUBTLE_CRYPTO -DENABLE_SVG_FONTS -DENABLE_SVG_OTF_CONVERTER -DENABLE_TELEPHONE_NUMBER_DETECTION -DENABLE_TEMPLATE_ELEMENT -DENABLE_CSS_TRAILING_WORD -DENABLE_USERSELECT_ALL -DENABLE_VIDEO -DENABLE_VIDEO_TRACK -DENABLE_DATACUE_VALUE -DENABLE_WEBGL -DENABLE_WEB_AUDIO -DENABLE_WEB_REPLAY -DENABLE_WEB_SOCKETS -DENABLE_WEB_TIMING -DENABLE_WEBVTT_REGIONS -DENABLE_XHR_TIMEOUT -DENABLE_XSLT -DENABLE_FTL_JIT=0 -DENABLE_JIT=0 -DENABLE_SATURATED_LAYOUT_ARITHMETIC -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.10 -g -fvisibility=hidden -fvisibility-inlines-hidden -fno-threadsafe-statics -Wno-sign-conversion -I/Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/JavaScriptCore.hmap -I/Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/Debug/include -I/Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/Debug/DerivedSources/JavaScriptCore -I. -Iicu -I/Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/Debug/usr/local/LLVMForJavaScriptCore/include -I/Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/Debug/ExtraIncludesForLocalLLVMBuild -I/usr/local/LLVMForJavaScriptCore/include -I/Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/Debug/usr/local/include -I/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include -I/Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/DerivedSources/x86_64 -I/Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/DerivedSources -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -Wimplicit-fallthrough -F/Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/Debug -include /Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/PrecompiledHeaders/JavaScriptCorePrefix-dvwvbkgrztglrrfntrgvjzazrpns/JavaScriptCorePrefix.h -MMD -MT dependencies -MF /Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/LowLevelInterpreter.d --serialize-diagnostics /Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/LowLevelInterpreter.dia -c /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp -o /Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Objects-normal/x86_64/LowLevelInterpreter.o In file included from /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:425: /Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/Debug/DerivedSources/JavaScriptCore/LLIntAssembly.h:693:29: error: code will never be executed [-Werror,-Wunreachable-code] t0.i = *CAST<intptr_t*>(cfr.i8p + 8); // JavaScriptCore/llint/LowLevelInterpreter64.asm:539 ^~~ /Volumes/Data/slave/yosemite-cloop-debug/build/WebKitBuild/Debug/DerivedSources/JavaScriptCore/LLIntAssembly.h:544:29: error: code will never be executed [-Werror,-Wunreachable-code] t0.i = *CAST<intptr_t*>(cfr.i8p + 8); // JavaScriptCore/llint/LowLevelInterpreter64.asm:539 ^~~ 2 errors generated.
(In reply to comment #6) > Seems to have broken JSC build: Looking at https://build.webkit.org/console?category=AppleMac this seems to be specific to the “LLINT CLoop” configuration. What’s the easiest way for me to build that configuration?
(In reply to comment #7) > (In reply to comment #6) > > Seems to have broken JSC build: > > Looking at https://build.webkit.org/console?category=AppleMac this seems to > be specific to the “LLINT CLoop” configuration. What’s the easiest way for > me to build that configuration? From the bot's stdio: perl ./Tools/Scripts/build-jsc --cloop --debug
(In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Seems to have broken JSC build: > > > > Looking at https://build.webkit.org/console?category=AppleMac this seems to > > be specific to the “LLINT CLoop” configuration. What’s the easiest way for > > me to build that configuration? > > From the bot's stdio: > perl ./Tools/Scripts/build-jsc --cloop --debug Thank you. I will look into this as soon as I can.
Tried to fix the LLINT CLoop build in <http://trac.webkit.org/r186273>.