Bug 146588 - Move shouldIgnoreAttributeCase inline function to Element.h
Summary: Move shouldIgnoreAttributeCase inline function to Element.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 146587
  Show dependency tree / graph
 
Reported: 2015-07-03 05:36 PDT by Csaba Osztrogonác
Modified: 2015-07-06 21:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.60 KB, patch)
2015-07-03 05:37 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-07-03 05:36:27 PDT 
inline bool shouldIgnoreAttributeCase(const Element& element)
{
    return element.isHTMLElement() && element.document().isHTMLDocument();
}

Now it is defined in Source/WebCore/dom/NamedNodeMap.cpp and Source/WebCore/dom/Element.cpp too.
But it makes impossible to include both of these files in an all-in-one build - bug146587.
To fix this issue, we should move this function to a header file.
Comment 1 Csaba Osztrogonác 2015-07-03 05:37:50 PDT 
Created attachment 256096 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-07-06 00:04:48 PDT 
ping?
Comment 3 WebKit Commit Bot 2015-07-06 21:28:07 PDT 
Comment on attachment 256096 [details]
Patch

Clearing flags on attachment: 256096

Committed r186398: <http://trac.webkit.org/changeset/186398>
Comment 4 WebKit Commit Bot 2015-07-06 21:28:11 PDT 
All reviewed patches have been landed.  Closing bug.