As part of https://bugs.webkit.org/show_bug.cgi?id=146060, most exceptions are caught to reject promise in case of promise-returning functions. Promise should also be rejected if the callee is not of the expected JS wrapper class name.
Created attachment 256092 [details] Patch
Comment on attachment 256092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256092&action=review > Source/WebCore/bindings/js/JSDOMPromise.h:63 > + JSDOMGlobalObject* globalObject = JSC::jsCast<JSDOMGlobalObject*>(state.lexicalGlobalObject()); Should be a reference. It can’t be null. > Source/WebCore/bindings/js/JSDOMPromise.h:64 > + JSC::JSPromiseDeferred* promiseDeferred = JSC::JSPromiseDeferred::create(&state, globalObject); Should be a reference. It can’t be null.
Comment on attachment 256092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256092&action=review >> Source/WebCore/bindings/js/JSDOMPromise.h:63 >> + JSDOMGlobalObject* globalObject = JSC::jsCast<JSDOMGlobalObject*>(state.lexicalGlobalObject()); > > Should be a reference. It can’t be null. ok >> Source/WebCore/bindings/js/JSDOMPromise.h:64 >> + JSC::JSPromiseDeferred* promiseDeferred = JSC::JSPromiseDeferred::create(&state, globalObject); > > Should be a reference. It can’t be null. ok
Created attachment 256197 [details] Patch for landing
Comment on attachment 256197 [details] Patch for landing Clearing flags on attachment: 256197 Committed r186312: <http://trac.webkit.org/changeset/186312>
All reviewed patches have been landed. Closing bug.