Bug 146585 – Promise-returning functions should reject promises if the callee is not of the expected type

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

As part of https://bugs.webkit.org/show_bug.cgi?id=146060, most exceptions are caught to reject promise in case of promise-returning functions.
Promise should also be rejected if the callee is not of the expected JS wrapper class name.

[youenn fablet]

Created attachment 256092 [details]
Patch

[Darin Adler]

Comment on attachment 256092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256092&action=review

> Source/WebCore/bindings/js/JSDOMPromise.h:63
> +    JSDOMGlobalObject* globalObject = JSC::jsCast<JSDOMGlobalObject*>(state.lexicalGlobalObject());

Should be a reference. It can’t be null.

> Source/WebCore/bindings/js/JSDOMPromise.h:64
> +    JSC::JSPromiseDeferred* promiseDeferred = JSC::JSPromiseDeferred::create(&state, globalObject);

Should be a reference. It can’t be null.

[youenn fablet]

Comment on attachment 256092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256092&action=review

>> Source/WebCore/bindings/js/JSDOMPromise.h:63
>> +    JSDOMGlobalObject* globalObject = JSC::jsCast<JSDOMGlobalObject*>(state.lexicalGlobalObject());
> 
> Should be a reference. It can’t be null.

ok

>> Source/WebCore/bindings/js/JSDOMPromise.h:64
>> +    JSC::JSPromiseDeferred* promiseDeferred = JSC::JSPromiseDeferred::create(&state, globalObject);
> 
> Should be a reference. It can’t be null.

ok

[youenn fablet]

Created attachment 256197 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 256197 [details]
Patch for landing

Clearing flags on attachment: 256197

Committed r186312: <http://trac.webkit.org/changeset/186312>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.