Bug 146584 - Add new sources to StyleAllInOne.cpp
Summary: Add new sources to StyleAllInOne.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 102647
  Show dependency tree / graph
 
Reported: 2015-07-03 03:25 PDT by Csaba Osztrogonác
Modified: 2015-07-08 14:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.53 KB, patch)
2015-07-03 03:26 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (8.55 KB, patch)
2015-07-06 00:06 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (8.54 KB, patch)
2015-07-07 10:03 PDT, Csaba Osztrogonác 		bfulgham: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-07-03 03:25:25 PDT 
The following sources aren't added to StyleAllInOne.cpp yet:
BasicShapes.cpp
GridResolvedPosition.cpp
ShapeValue.cpp

Additionally we can remove useless ifdef guard from StyleAllInOne.cpp,
StyleGridData.cpp, StyleGridItemData.cpp and StyleScrollSnapPoints.cpp
sources are properly guarded, we don't need duplicated guards.
Comment 1 Csaba Osztrogonác 2015-07-03 03:26:23 PDT 
Created attachment 256091 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-07-06 00:06:37 PDT 
Created attachment 256194 [details]
Patch

Let's see the Windows EWS aqain, maybe it is in better shape.
Comment 3 Csaba Osztrogonác 2015-07-07 10:03:06 PDT 
Created attachment 256305 [details]
Patch

one more shot for the Windows EWS
Comment 4 Brent Fulgham 2015-07-08 14:14:10 PDT 
Comment on attachment 256305 [details]
Patch

r=me
Comment 5 Brent Fulgham 2015-07-08 14:39:14 PDT 
Committed r186528: <http://trac.webkit.org/changeset/186528>