Bug 146569 - Captions' highlights do not entirely cover their constituent text
Summary: Captions' highlights do not entirely cover their constituent text
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-02 18:15 PDT by Myles C. Maxfield
Modified: 2015-07-07 15:46 PDT (History)
6 users (show)

See Also:

Attachments
Patch (30.83 KB, patch)
2015-07-02 18:26 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (30.89 KB, patch)
2015-07-02 18:29 PDT, Myles C. Maxfield 		simon.fraser: review-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-07-02 18:15:42 PDT 
Captions' highlights do not entirely cover their constituent text
Comment 1 Myles C. Maxfield 2015-07-02 18:26:57 PDT 
Created attachment 256064 [details]
Patch
Comment 2 Myles C. Maxfield 2015-07-02 18:27:42 PDT 
<rdar://problem/21498411>
Comment 3 Myles C. Maxfield 2015-07-02 18:29:31 PDT 
Created attachment 256065 [details]
Patch
Comment 4 Simon Fraser (smfr) 2015-07-02 23:23:14 PDT 
Comment on attachment 256065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256065&action=review

> Source/WebCore/ChangeLog:18
> +        fallback metrics of its contents. This property, however, requires that the
> +        span be turned into a div (which is fine because these elements are internal
> +        to WebKit).

Is this OK? Is there ever more than one on a line?
Comment 5 Myles C. Maxfield 2015-07-07 13:34:27 PDT 
Comment on attachment 256065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256065&action=review

>> Source/WebCore/ChangeLog:18
>> +        to WebKit).
> 
> Is this OK? Is there ever more than one on a line?

There is never more than one in a row. See VTTCue::getDisplayTree().
Comment 6 Myles C. Maxfield 2015-07-07 14:43:03 PDT 
This actually changes behavior if the text line-wraps.
Comment 7 Myles C. Maxfield 2015-07-07 14:50:16 PDT 
Hyatt says that line-box-contain should work on inline elements. I need to figure out why it didn't seem to work for me earlier.
Comment 8 Simon Fraser (smfr) 2015-07-07 14:58:38 PDT 
Comment on attachment 256065 [details]
Patch

r- then!
Comment 9 Myles C. Maxfield 2015-07-07 15:40:00 PDT 
line-box-contain only grows the root line box. It doesn't grow the inlineflowboxes which are the things which paint the background.
Comment 10 Myles C. Maxfield 2015-07-07 15:42:42 PDT 
hyatt says "honestly if you have a fix that works pretty well, i’d just leave this alone"