Bug 146566 – REGRESSION (r178097): HTMLSelectElement.add(option, undefined) prepends option to the list of options; should append to the end of the list of options

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

Following the change made in bug #139179 (http://trac.webkit.org/changeset/178097), calling HTMLSelectElement.add(O, undefined) prepends O to the list of options where O is either an HTML option element or an HTML optgroup element. But it should append O to the end of the list of options.

[Daniel Bates]

Created attachment 256056 [details]
Example

[Radar WebKit Bug Importer]

<rdar://problem/21663919>

[Chris Dumez]

Relevant specs:
https://html.spec.whatwg.org/multipage/forms.html#dom-select-add

which points to:
https://html.spec.whatwg.org/multipage/infrastructure.html#dom-htmloptionscollection-add

which says in this case to call the DOM insertBefore() method on the parent node, with element as the first argument and null (in our case) as the second argument.

https://dom.spec.whatwg.org/#dom-node-insertbefore
->
https://dom.spec.whatwg.org/#concept-node-insert

"
For each newNode in nodes, in tree order, run these substeps:
1. Insert newNode into parent before child or at the end of parent if child is null.
2. Run the insertion steps with newNode.
"

Ok, so even though it is hard to follow, the spec does say to insert "at the end of parent if child is null".

[Chris Dumez]

Created attachment 256114 [details]
Patch

[Chris Dumez]

Created attachment 256120 [details]
Patch

[Build Bot]

Comment on attachment 256120 [details]
Patch

Attachment 256120 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4714810553925632

New failing tests:
fast/dom/HTMLSelectElement/add.html

[Build Bot]

Created attachment 256122 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Chris Dumez]

Created attachment 256123 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 256123 [details]
Patch

Clearing flags on attachment: 256123

Committed r186275: <http://trac.webkit.org/changeset/186275>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.