Bug 146563 – ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads

rdar://problem/21640050

[Brady Eidson]

Created attachment 256046 [details]
Patch v1

EWS running in concert with layout tests on my machine - Still making sure no behavior changed.

[Brady Eidson]

(To be clear on the Windows EWS failure, it's not because of this patch.)

[Geoffrey Garen]

Comment on attachment 256046 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=256046&action=review

Please fix Windows if it is truly broken.

> Tools/WebKitTestRunner/TestInvocation.cpp:189
> +    WKPageLoadURLWithShouldOpenExternalURLsPolicy(TestController::singleton().mainWebView()->page(), m_url.get(), false);

Please put false in well-named local variable.

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 256046 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256046&action=review
> 
> Please fix Windows if it is truly broken.

It is not.

> 
> > Tools/WebKitTestRunner/TestInvocation.cpp:189
> > +    WKPageLoadURLWithShouldOpenExternalURLsPolicy(TestController::singleton().mainWebView()->page(), m_url.get(), false);
> 
> Please put false in well-named local variable.

Willdo.

Thanks!

[Brady Eidson]

https://trac.webkit.org/changeset/186371