Bug 146563 - ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads
Summary: ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-02 16:18 PDT by Brady Eidson
Modified: 2015-07-06 19:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (4.72 KB, patch)
2015-07-02 16:21 PDT, Brady Eidson 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-07-02 16:18:23 PDT 
ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads

rdar://problem/21640050
Comment 1 Brady Eidson 2015-07-02 16:21:30 PDT 
Created attachment 256046 [details]
Patch v1

EWS running in concert with layout tests on my machine - Still making sure no behavior changed.
Comment 2 Brady Eidson 2015-07-05 10:37:36 PDT 
(To be clear on the Windows EWS failure, it's not because of this patch.)
Comment 3 Geoffrey Garen 2015-07-06 12:59:23 PDT 
Comment on attachment 256046 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=256046&action=review

Please fix Windows if it is truly broken.

> Tools/WebKitTestRunner/TestInvocation.cpp:189
> +    WKPageLoadURLWithShouldOpenExternalURLsPolicy(TestController::singleton().mainWebView()->page(), m_url.get(), false);

Please put false in well-named local variable.
Comment 4 Brady Eidson 2015-07-06 13:06:02 PDT 
(In reply to comment #3)
> Comment on attachment 256046 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256046&action=review
> 
> Please fix Windows if it is truly broken.

It is not.

> 
> > Tools/WebKitTestRunner/TestInvocation.cpp:189
> > +    WKPageLoadURLWithShouldOpenExternalURLsPolicy(TestController::singleton().mainWebView()->page(), m_url.get(), false);
> 
> Please put false in well-named local variable.

Willdo.

Thanks!
Comment 5 Brady Eidson 2015-07-06 13:15:25 PDT 
https://trac.webkit.org/changeset/186371