Bug 146559 - [WinCairo][WebGL] Enable HLSL.
Summary: [WinCairo][WebGL] Enable HLSL.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2015-07-02 13:54 PDT by peavo
Modified: 2015-07-03 11:46 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.56 KB, patch)
2015-07-02 13:58 PDT, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-07-02 13:54:33 PDT 
Enabling High Level Shader Language seems to be needed for WebGL to work.
Comment 1 peavo 2015-07-02 13:58:36 PDT 
Created attachment 256032 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-02 14:00:43 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Alex Christensen 2015-07-03 10:55:03 PDT 
Comment on attachment 256032 [details]
Patch

I wondered why it wasn't working.  Thanks for looking into this.
Comment 4 peavo 2015-07-03 11:05:52 PDT 
(In reply to comment #3)
> Comment on attachment 256032 [details]
> Patch
> 
> I wondered why it wasn't working.  Thanks for looking into this.

Thanks for reviewing!

When not running from Visual Studio, it is also important to copy "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\bin\D3Dcompiler_47.dll" to the same folder as WinLauncher.exe, or have it in the PATH. Otherwise ANGLE will fail to initialize.
Comment 5 WebKit Commit Bot 2015-07-03 11:46:42 PDT 
Comment on attachment 256032 [details]
Patch

Clearing flags on attachment: 256032

Committed r186262: <http://trac.webkit.org/changeset/186262>
Comment 6 WebKit Commit Bot 2015-07-03 11:46:45 PDT 
All reviewed patches have been landed.  Closing bug.