Bug 146519 - bmalloc: Shrink the super chunk size
Summary: bmalloc: Shrink the super chunk size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-01 11:28 PDT by Geoffrey Garen
Modified: 2015-07-02 16:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2015-07-01 11:33 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (567.77 KB, application/zip)
2015-07-01 12:08 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (673.67 KB, application/zip)
2015-07-01 12:11 PDT, Build Bot 		no flags Details
Patch (1.93 KB, patch)
2015-07-01 16:53 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2015-07-01 11:28:10 PDT 
bmalloc: Shrink the super chunk size
Comment 1 Geoffrey Garen 2015-07-01 11:33:45 PDT 
Created attachment 255936 [details]
Patch
Comment 2 Andreas Kling 2015-07-01 11:51:59 PDT 
Comment on attachment 255936 [details]
Patch

r=me assuming EWS doesn't choke.
Comment 3 Build Bot 2015-07-01 12:08:24 PDT 
Comment on attachment 255936 [details]
Patch

Attachment 255936 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4779764149649408

New failing tests:
fast/css/large-list-of-rules-crash.html
Comment 4 Build Bot 2015-07-01 12:08:27 PDT 
Created attachment 255944 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-07-01 12:11:56 PDT 
Comment on attachment 255936 [details]
Patch

Attachment 255936 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4714604395495424

New failing tests:
fast/css/large-list-of-rules-crash.html
Comment 6 Build Bot 2015-07-01 12:11:59 PDT 
Created attachment 255946 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Geoffrey Garen 2015-07-01 16:53:14 PDT 
Created attachment 255972 [details]
Patch
Comment 8 Andreas Kling 2015-07-01 17:01:52 PDT 
Comment on attachment 255972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255972&action=review

> Source/bmalloc/bmalloc/SegregatedFreeList.h:63
> +    std::array<FreeList, 17> m_freeLists;

Can this be math instead?
Comment 9 Geoffrey Garen 2015-07-02 10:47:48 PDT 
> > Source/bmalloc/bmalloc/SegregatedFreeList.h:63
> > +    std::array<FreeList, 17> m_freeLists;
> 
> Can this be math instead?

We need to compute "log base 2 of largeMax minus some other constants". I don't know how to compute the log part at compile time.
Comment 10 Geoffrey Garen 2015-07-02 16:32:47 PDT 
Comment on attachment 255972 [details]
Patch

Clearing flags on attachment: 255972

Committed r186242: <http://trac.webkit.org/changeset/186242>
Comment 11 Geoffrey Garen 2015-07-02 16:32:53 PDT 
All reviewed patches have been landed.  Closing bug.