Bug 146514 - Ignore Visual Studio warning in SegmentedVector
Summary: Ignore Visual Studio warning in SegmentedVector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-01 09:35 PDT by Alex Christensen
Modified: 2015-07-01 17:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.09 KB, patch)
2015-07-01 09:37 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.14 KB, patch)
2015-07-01 12:03 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-07-01 09:35:49 PDT 
SegmentedVector intentionally has an array of size 0.  This is creating a lot of C4200 warnings making the build logs hard to read and find real errors.  Let's hide this warning locally so we can still find problems elsewhere.
Comment 1 Alex Christensen 2015-07-01 09:37:02 PDT 
Created attachment 255924 [details]
Patch
Comment 2 Darin Adler 2015-07-01 09:41:00 PDT 
Comment on attachment 255924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255924&action=review

> Source/WTF/wtf/SegmentedVector.h:192
> +#pragma warning(push)
> +#pragma warning(disable: 4200)
>              T entries[0];
> +#pragma warning(pop)

Need to wrap #pragma in appropriate #if.
Comment 3 Alex Christensen 2015-07-01 12:03:43 PDT 
Created attachment 255943 [details]
Patch
Comment 4 WebKit Commit Bot 2015-07-01 17:08:49 PDT 
Comment on attachment 255943 [details]
Patch

Clearing flags on attachment: 255943

Committed r186207: <http://trac.webkit.org/changeset/186207>
Comment 5 WebKit Commit Bot 2015-07-01 17:08:53 PDT 
All reviewed patches have been landed.  Closing bug.