Bug 146513 - Check shouldOpenExternalURLs instead of isProcessingUserGesture before passing URL to LaunchServices
Summary: Check shouldOpenExternalURLs instead of isProcessingUserGesture before passin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-01 08:58 PDT by Brady Eidson
Modified: 2015-07-01 09:54 PDT (History)
0 users

See Also:

Attachments
Patch v1 (1.90 KB, patch)
2015-07-01 09:00 PDT, Brady Eidson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-07-01 08:58:17 PDT 
Check shouldOpenExternalURLs instead of isProcessingUserGesture before passing URL to LaunchServices

In radar as rdar://problem/20577859
Comment 1 Brady Eidson 2015-07-01 08:59:04 PDT 
This fixes cases where the URL undergoes 1 or more redirects, during which we lose the original value of isProcessingUserGesture
Comment 2 Brady Eidson 2015-07-01 09:00:44 PDT 
Created attachment 255923 [details]
Patch v1
Comment 3 Darin Adler 2015-07-01 09:36:38 PDT 
Comment on attachment 255923 [details]
Patch v1

Does shouldOpenExternalURLs include consideration of user gesture or is it a completely orthogonal concept?
Comment 4 Brady Eidson 2015-07-01 09:52:58 PDT 
(In reply to comment #3)
> Comment on attachment 255923 [details]
> Patch v1
> 
> Does shouldOpenExternalURLs include consideration of user gesture or is it a
> completely orthogonal concept?

It considers user gestures.
Comment 5 Brady Eidson 2015-07-01 09:54:35 PDT 
https://trac.webkit.org/changeset/186178