Bug 146476 - WKWebView snapshots have the wrong scale after rotation
Summary: WKWebView snapshots have the wrong scale after rotation
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Depends on:
Reported: 2015-06-30 15:22 PDT by Tim Horton
Modified: 2015-07-01 14:36 PDT (History)
4 users (show)

See Also:

Patch (9.97 KB, patch)
2015-06-30 15:22 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (5.62 KB, patch)
2015-07-01 11:43 PDT, Tim Horton
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-06-30 15:22:00 PDT
WKWebView snapshots have the wrong scale after rotation
Comment 1 Tim Horton 2015-06-30 15:22:26 PDT
Created attachment 255865 [details]
Comment 2 Tim Horton 2015-06-30 15:23:36 PDT
There are still a lot of weird edge cases with the snapshotting timing, so I'm going to look into having the software snapshot case go through the remote layer tree commit mechanism so that we always get the "right" answer, but if that doesn't work out this patch fixes one of the many bugs.
Comment 3 Tim Horton 2015-07-01 11:43:15 PDT
Created attachment 255938 [details]
Comment 4 WebKit Commit Bot 2015-07-01 11:45:56 PDT
Attachment 255938 [details] did not pass style-queue:

ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:216:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2015-07-01 14:36:13 PDT