Bug 146463 – [Cocoa] Support bold and thin italicized system fonts

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[iOS] Support bold and thin italicized system fonts

[Myles C. Maxfield]

Created attachment 255845 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/20948885>

[Myles C. Maxfield]

Comment on attachment 255845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255845&action=review

> Source/WebCore/ChangeLog:3
> +        [iOS] Support bold and thin italicized system fonts

Should be marked as [Cocoa]

[Build Bot]

Comment on attachment 255845 [details]
Patch

Attachment 255845 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6515086898233344

New failing tests:
fast/text/weighted-italicized-system-font.html

[Build Bot]

Created attachment 255846 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 255845 [details]
Patch

Attachment 255845 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4962156378324992

New failing tests:
fast/text/weighted-italicized-system-font.html

[Build Bot]

Created attachment 255848 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Myles C. Maxfield]

Looks like Mavericks doesn't have true italics. I'll try on Yosemite before updating TestExpectations.

[Myles C. Maxfield]

Created attachment 255900 [details]
Patch

[Darin Adler]

Comment on attachment 255900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255900&action=review

> Source/WebCore/platform/graphics/mac/FontCacheMac.mm:244
> +        if (desiredTraits & NSFontItalicTrait) {
> +            NSFontManager *fontManager = [NSFontManager sharedFontManager];
> +            result = [fontManager convertFont:result toHaveTrait:desiredTraits];
> +        }

Would read better without the local variable.

> LayoutTests/platform/mac-mavericks/TestExpectations:23
> +# Mavericks doesn't have an italic system font
> +fast/text/weighted-italicized-system-font.html [ Failure ]

I think a different expected.html would be a better way to deal with this than expecting failure. We want to make sure that it correctly gives a non-italic result, right?

[Myles C. Maxfield]

Created attachment 255933 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 255933 [details]
Patch for committing

Clearing flags on attachment: 255933

Committed r186205: <http://trac.webkit.org/changeset/186205>