In addition to keeping track of the new media session, we should: - pause the media element if it is 'active' in the current media session - remove the element from the current media session - release the current media session if there are no more active media elements - set the default media session if the new media session is null - update the 'kind' attribute to match the kind of the new media session
<rdar://problem/21613814>
Created attachment 255831 [details] Patch
Comment on attachment 255831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255831&action=review > Source/WebCore/html/HTMLMediaElement.cpp:6490 > + ASSERT_ARG(session, session); If the function requires a non-null pointer, then the type it takes should be MediaSession&, not MediaSession*.
(In reply to comment #3) > Comment on attachment 255831 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255831&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:6490 > > + ASSERT_ARG(session, session); > > If the function requires a non-null pointer, then the type it takes should > be MediaSession&, not MediaSession*. Fixed.
Committed r186123: <http://trac.webkit.org/changeset/186123>