Bug 146457 - [Win] webViewAddMessageToConsole always gets 1 for isError
Summary: [Win] webViewAddMessageToConsole always gets 1 for isError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-30 09:14 PDT by Brent Fulgham
Modified: 2015-06-30 10:34 PDT (History)
6 users (show)

See Also:


Attachments
Correct argument to delegate method. (1.95 KB, patch)
2015-06-30 09:24 PDT, Brent Fulgham
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-06-30 09:14:02 PDT
The code that calls the Windows API "webViewAddMessageToConsole" has a hard coded "isError = True" argument. This causes console output on Windows to improperly show errors in the many cases where the log content is informational.
Comment 1 Brent Fulgham 2015-06-30 09:14:31 PDT
<rdar://problem/21606395>
Comment 2 Brent Fulgham 2015-06-30 09:24:43 PDT
Created attachment 255823 [details]
Correct argument to delegate method.
Comment 3 Brent Fulgham 2015-06-30 10:34:07 PDT
Committed in r186121. <http://trac.webkit.org/changeset/186121>