Bug 146443 - Get rid of unused WKSI functions
Summary: Get rid of unused WKSI functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-29 18:08 PDT by Anders Carlsson
Modified: 2015-06-30 15:56 PDT (History)
1 user (show)

See Also:

Attachments
Patch (11.50 KB, patch)
2015-06-29 18:09 PDT, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-06-29 18:08:33 PDT 
Get rid of unused WKSI functions
Comment 1 Anders Carlsson 2015-06-29 18:09:35 PDT 
Created attachment 255802 [details]
Patch
Comment 2 Tim Horton 2015-06-29 18:11:50 PDT 
Comment on attachment 255802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255802&action=review

> Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:340
> +    WKDestroyRenderingResources();

You should get rid of WKDestroyRenderingResources and just call what it calls here, no?
Comment 3 Anders Carlsson 2015-06-30 10:12:55 PDT 
Committed r186118: <http://trac.webkit.org/changeset/186118>
Comment 4 Carlos Alberto Lopez Perez 2015-06-30 15:56:29 PDT 
(In reply to comment #3)
> Committed r186118: <http://trac.webkit.org/changeset/186118>

This broke (again) the GTK and EFL build.

Fix landed in https://trac.webkit.org/changeset/186140