WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
146443
Get rid of unused WKSI functions
https://bugs.webkit.org/show_bug.cgi?id=146443
Summary
Get rid of unused WKSI functions
Anders Carlsson
Reported
2015-06-29 18:08:33 PDT
Get rid of unused WKSI functions
Attachments
Patch
(11.50 KB, patch)
2015-06-29 18:09 PDT
,
Anders Carlsson
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2015-06-29 18:09:35 PDT
Created
attachment 255802
[details]
Patch
Tim Horton
Comment 2
2015-06-29 18:11:50 PDT
Comment on
attachment 255802
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=255802&action=review
> Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:340 > + WKDestroyRenderingResources();
You should get rid of WKDestroyRenderingResources and just call what it calls here, no?
Anders Carlsson
Comment 3
2015-06-30 10:12:55 PDT
Committed
r186118
: <
http://trac.webkit.org/changeset/186118
>
Carlos Alberto Lopez Perez
Comment 4
2015-06-30 15:56:29 PDT
(In reply to
comment #3
)
> Committed
r186118
: <
http://trac.webkit.org/changeset/186118
>
This broke (again) the GTK and EFL build. Fix landed in
https://trac.webkit.org/changeset/186140
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug