Bug 146441 - Flag sync XHRs from the network process so they can be handled appropriately
Summary: Flag sync XHRs from the network process so they can be handled appropriately
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-29 16:44 PDT by Brady Eidson
Modified: 2015-06-29 17:33 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (5.62 KB, patch)
2015-06-29 17:02 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-06-29 16:44:28 PDT 
Flag sync XHRs from the network process so they can be handled appropriately

This is a requirement (for Mac/CFNetwork at least) lost in the transition to OOP networking.

<rdar://problem/21579162>
Comment 1 Brady Eidson 2015-06-29 17:02:28 PDT 
Created attachment 255798 [details]
Patch v1
Comment 2 Darin Adler 2015-06-29 17:11:41 PDT 
Comment on attachment 255798 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=255798&action=review

> Source/WebCore/platform/network/ResourceHandleClient.h:87
> +        virtual bool loadingSynchronousXHR() { return false; }

Maybe isPerformingSynchronousLoad? Maybe shouldScheduleSynchronousLoad?
Comment 3 WebKit Commit Bot 2015-06-29 17:33:15 PDT 
Comment on attachment 255798 [details]
Patch v1

Clearing flags on attachment: 255798

Committed r186099: <http://trac.webkit.org/changeset/186099>
Comment 4 WebKit Commit Bot 2015-06-29 17:33:19 PDT 
All reviewed patches have been landed.  Closing bug.