Implementing enumerateDevices

[Matthew Daiter]

Wanted to implement enumerateDevices

[Radar WebKit Bug Importer]

<rdar://problem/21599847>

[Matthew Daiter]

Created attachment 258813 [details]
Patch

[Matthew Daiter]

Created attachment 258845 [details]
Patch

[Matthew Daiter]

Created attachment 258851 [details]
Patch

[Matthew Daiter]

Created attachment 258860 [details]
Patch

[Matthew Daiter]

Created attachment 258901 [details]
Patch

[Matthew Daiter]

Created attachment 258906 [details]
Patch

[Matthew Daiter]

Created attachment 258917 [details]
Patch

[Matthew Daiter]

Created attachment 258929 [details]
Patch

[Eric Carlson]

Comment on attachment 258929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258929&action=review

> Source/WebCore/platform/mediastream/MediaDevicesPrivate.cpp:32
>  #include "MediaStreamTrackSourcesRequestClient.h"

Nit: this isn't necessary, it is included by the .h file.

> Source/WebCore/platform/mediastream/MediaDevicesPrivate.h:51
> +    const String& requestOrigin() const override { return emptyString(); }

Why an empty string? This needs a FIXME at the very least.

[Matthew Daiter]

Created attachment 259044 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 259044 [details]
Patch

Clearing flags on attachment: 259044

Committed r188493: <http://trac.webkit.org/changeset/188493>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.