Bug 146422 - Crash under _layoutForNodeHighlight: when inspecting espn.com
Summary: Crash under _layoutForNodeHighlight: when inspecting espn.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-29 13:39 PDT by Simon Fraser (smfr)
Modified: 2015-06-30 15:01 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2015-06-29 13:40 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (3.28 KB, patch)
2015-06-29 14:03 PDT, Simon Fraser (smfr) 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-06-29 13:39:38 PDT 
Crash under _layoutForNodeHighlight: when inspecting espn.com
Comment 1 Simon Fraser (smfr) 2015-06-29 13:40:34 PDT 
Created attachment 255770 [details]
Patch
Comment 2 Joseph Pecoraro 2015-06-29 13:48:19 PDT 
Comment on attachment 255770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255770&action=review

Would be really good to know what type of node we aren't highlighting / getting a quad for.

> Source/WebKit2/UIProcess/WKInspectorHighlightView.mm:215
>  - (void)_layoutForNodeHighlight:(const Highlight&)highlight

WebKit1 has nearly identical code which will need to be updated.
Comment 3 Simon Fraser (smfr) 2015-06-29 14:03:22 PDT 
Created attachment 255774 [details]
Patch
Comment 4 Joseph Pecoraro 2015-06-29 14:15:59 PDT 
Comment on attachment 255774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255774&action=review

r=me

> Source/WebKit/mac/WebInspector/WebNodeHighlightView.mm:266
> +    NSUInteger numLayers = (NSUInteger)h->quads.size();

Not really sure the NSInteger cast is necessary. This could just be:

    if (!h->quads.size()) {
Comment 5 Simon Fraser (smfr) 2015-06-30 15:01:51 PDT 
https://trac.webkit.org/r186134