Bug 146387 - Make converting JSString to StringView idiomatically safe
Summary: Make converting JSString to StringView idiomatically safe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-27 09:31 PDT by Darin Adler
Modified: 2015-06-27 15:54 PDT (History)
2 users (show)

See Also:


Attachments
Patch (21.92 KB, patch)
2015-06-27 13:51 PDT, Darin Adler
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2015-06-27 09:31:19 PDT
Make converting JSString to StringView idiomatically safe
Comment 1 Darin Adler 2015-06-27 13:51:13 PDT
Created attachment 255704 [details]
Patch
Comment 2 Anders Carlsson 2015-06-27 14:46:38 PDT
Comment on attachment 255704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255704&action=review

> Source/JavaScriptCore/runtime/JSString.h:456
> +    const JSString* volatile m_string { nullptr };

Might be useful to put a comment here stating why this needs to be volatile.
Comment 3 Darin Adler 2015-06-27 15:54:03 PDT
Committed r186037: <http://trac.webkit.org/changeset/186037>