Bug 146376 - REGRESSION: Web Inspector: Jump to Definition is broken
Summary: REGRESSION: Web Inspector: Jump to Definition is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-26 19:35 PDT by Nikita Vasilyev
Modified: 2015-06-29 12:44 PDT (History)
8 users (show)

See Also:


Attachments
Animated GIF of the problem (85.31 KB, image/gif)
2015-06-26 19:35 PDT, Nikita Vasilyev
no flags Details
Reduction (69 bytes, text/html)
2015-06-26 19:43 PDT, Nikita Vasilyev
no flags Details
[PATCH] Proposed Fix (1.59 KB, patch)
2015-06-29 12:00 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-06-26 19:35:41 PDT
Created attachment 255685 [details]
Animated GIF of the problem

:(
Comment 1 Radar WebKit Bug Importer 2015-06-26 19:36:04 PDT
<rdar://problem/21576867>
Comment 2 Nikita Vasilyev 2015-06-26 19:43:55 PDT
Created attachment 255687 [details]
Reduction

Steps:
1. Open click.html
2. Enter "dir({clicked})"
3. Right-click "clicked" and select "Jump to Definition" from the context menu.

Expected:
click.html opens in the debugger or resources tab with the "function clicked() {" line highlighted.

Actual:
Nothing happens.
Comment 3 Joseph Pecoraro 2015-06-29 10:56:31 PDT
Should be as easy as making WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject's WebInspector.showSourceCodeLocation(sourceCodeLocation) include the second parameter that forces switching tabs. We get the right location.
Comment 4 Joseph Pecoraro 2015-06-29 12:00:16 PDT
Created attachment 255765 [details]
[PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2015-06-29 12:44:48 PDT
Comment on attachment 255765 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 255765

Committed r186080: <http://trac.webkit.org/changeset/186080>
Comment 6 WebKit Commit Bot 2015-06-29 12:44:51 PDT
All reviewed patches have been landed.  Closing bug.