Bug 146370 - Media Session: update an element's media session when the 'kind' is updated
Summary: Media Session: update an element's media session when the 'kind' is updated
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency tree / graph
 
Reported: 2015-06-26 17:32 PDT by Matt Rajca
Modified: 2015-07-06 10:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.87 KB, patch)
2015-06-30 15:11 PDT, Matt Rajca 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-06-26 17:32:12 PDT 
A media element's media session should be updated when its "kind" is set, changed, or removed.
Comment 1 Radar WebKit Bug Importer 2015-06-26 17:33:59 PDT 
<rdar://problem/21575667>
Comment 2 Matt Rajca 2015-06-30 15:11:10 PDT 
Created attachment 255863 [details]
Patch
Comment 3 WebKit Commit Bot 2015-06-30 15:14:14 PDT 
Attachment 255863 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLMediaElement.cpp:6516:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/html/HTMLMediaElement.h:560:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Matt Rajca 2015-07-06 10:33:19 PDT 
The 'kind' attribute has been removed from the Media Session in favor of the 'session' attribute.