Bug 146366 - [Mac] Muted videos should not automatically play to AppleTV
Summary: [Mac] Muted videos should not automatically play to AppleTV
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
Keywords: InRadar
Depends on:
Reported: 2015-06-26 14:17 PDT by Eric Carlson
Modified: 2015-06-26 16:35 PDT (History)
1 user (show)

See Also:

Proposed patch. (7.66 KB, patch)
2015-06-26 14:35 PDT, Eric Carlson
dino: review+
Details | Formatted Diff | Diff
Updated patch. (7.83 KB, patch)
2015-06-26 14:45 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-06-26 14:17:50 PDT
A video that is muted initially is more likely to be a background video, so don't send it to the AppelTV automatically.
Comment 1 Eric Carlson 2015-06-26 14:18:46 PDT
Comment 2 Eric Carlson 2015-06-26 14:35:53 PDT
Created attachment 255666 [details]
Proposed patch.
Comment 3 Dean Jackson 2015-06-26 14:39:05 PDT
Comment on attachment 255666 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=255666&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::HTMLMediaElement::setMuted): Update media state asynchronously to multiple state
> +          changes to be coalesced.

Typo: I think you meant "so multiple state changes can"
Comment 4 Eric Carlson 2015-06-26 14:45:49 PDT
Created attachment 255667 [details]
Updated patch.
Comment 5 Eric Carlson 2015-06-26 16:35:01 PDT
Committed r186016: https://trac.webkit.org/r186016