Only Media Sessions created with the "content" kind should have media remote controls.
<rdar://problem/21569300>
Created attachment 255682 [details] Patch
Comment on attachment 255682 [details] Patch Attachment 255682 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5461893003083776 New failing tests: media/session/controls-existence.html
Created attachment 255683 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 255682 [details] Patch Attachment 255682 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4581045944975360 New failing tests: media/session/controls-existence.html
Created attachment 255684 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 255682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255682&action=review > LayoutTests/ChangeLog:9 > + * media/session/controls-existence-expected.txt: Added. > + * media/session/controls-existence.html: Added. You need to mark the new test as Skipped in LayoutTests/platform/mac/TestExpectations. > LayoutTests/media/session/controls-existence-expected.txt:6 > +EXPECTED (session.controls != 'null') OK > +EXPECTED (session.controls == 'null') OK > +EXPECTED (session.controls == 'null') OK > +EXPECTED (session.controls == 'null') OK Nit: It can be helpful to have more context about what is being tested in the results, so it would be helpful to log the session type. For example: run("session = new MediaSession('content')"); testExpected("session.controls", null, '!='); or maybe testExpected("new MediaSession('content').controls", null, '!='); etc.
(In reply to comment #7) > Comment on attachment 255682 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255682&action=review > > > LayoutTests/ChangeLog:9 > > + * media/session/controls-existence-expected.txt: Added. > > + * media/session/controls-existence.html: Added. > > You need to mark the new test as Skipped in > LayoutTests/platform/mac/TestExpectations. Done. Wasn't sure if they were opt-in or opt-out. > > > LayoutTests/media/session/controls-existence-expected.txt:6 > > +EXPECTED (session.controls != 'null') OK > > +EXPECTED (session.controls == 'null') OK > > +EXPECTED (session.controls == 'null') OK > > +EXPECTED (session.controls == 'null') OK > > Nit: It can be helpful to have more context about what is being tested in > the results, so it would be helpful to log the session type. For example: > > run("session = new MediaSession('content')"); > testExpected("session.controls", null, '!='); I'll do that. > > or maybe > > testExpected("new MediaSession('content').controls", null, '!='); > > etc.
Committed r186070: <http://trac.webkit.org/changeset/186070>