Bug 146342 - [EFL] Remove unnecessary overriden methods from ScrollBarEfl
Summary: [EFL] Remove unnecessary overriden methods from ScrollBarEfl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 146327
  Show dependency treegraph
 
Reported: 2015-06-26 03:50 PDT by Csaba Osztrogonác
Modified: 2015-06-29 03:11 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.27 KB, patch)
2015-06-26 03:51 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-06-26 03:50:25 PDT
bug146327 is going to remove the invalidate method, which would break 
the EFL build. But we can remove it from ScrollBarEfl now, because they
are exactly same.

Additionally we can remove setFrameRect, setParent and frameRectsChanged too.
Comment 1 Csaba Osztrogonác 2015-06-26 03:51:22 PDT
Created attachment 255628 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-26 06:06:02 PDT
Comment on attachment 255628 [details]
Patch

Clearing flags on attachment: 255628

Committed r185995: <http://trac.webkit.org/changeset/185995>
Comment 3 WebKit Commit Bot 2015-06-26 06:06:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Anders Carlsson 2015-06-26 09:41:41 PDT
Looks like we could just remove all of ScrollbarEfl now?
Comment 5 Csaba Osztrogonác 2015-06-26 09:44:37 PDT
(In reply to comment #4)
> Looks like we could just remove all of ScrollbarEfl now?

I will check it and submit a patch if it is possible.
Comment 6 Csaba Osztrogonác 2015-06-29 03:11:22 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > Looks like we could just remove all of ScrollbarEfl now?
> 
> I will check it and submit a patch if it is possible.

It seems it can be removed, at least bug143566 would like to do it.