Bug 146334 - [EFL] Purge unused favicons from IconDatabase after 30 days
Summary: [EFL] Purge unused favicons from IconDatabase after 30 days
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hyungwook Lee
URL:
Keywords:
Depends on: 82346
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-25 17:47 PDT by Hyungwook Lee
Modified: 2015-06-29 03:10 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.85 KB, patch)
2015-06-25 17:55 PDT, Hyungwook Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hyungwook Lee 2015-06-25 17:47:19 PDT
We need purge unused favicons from IconDatabase for database size control.
Comment 1 Hyungwook Lee 2015-06-25 17:55:54 PDT
Created attachment 255604 [details]
Patch
Comment 2 Gyuyoung Kim 2015-06-25 20:01:46 PDT
Comment on attachment 255604 [details]
Patch

I agree with keeping favicons for 30 days as GTK port. LGTM. BTW, it seems there is some missing APIs to support favicon. For example, EFL port needs to support to clear all favicons by EWK APIs. Could you do that ?
Comment 3 Hyungwook Lee 2015-06-25 23:19:53 PDT
I will implement remove all icons API for EFL port soon.
Comment 4 WebKit Commit Bot 2015-06-29 03:10:54 PDT
Comment on attachment 255604 [details]
Patch

Clearing flags on attachment: 255604

Committed r186068: <http://trac.webkit.org/changeset/186068>
Comment 5 WebKit Commit Bot 2015-06-29 03:10:58 PDT
All reviewed patches have been landed.  Closing bug.