Bug 146329 - [iOS WK2] Swiping back just after scrolling can cause some tiles to disappear
Summary: [iOS WK2] Swiping back just after scrolling can cause some tiles to disappear
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-25 16:02 PDT by Simon Fraser (smfr)
Modified: 2015-06-25 17:31 PDT (History)
10 users (show)

See Also:

Attachments
Patch (15.06 KB, patch)
2015-06-25 16:28 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (15.28 KB, patch)
2015-06-25 17:03 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (16.61 KB, patch)
2015-06-25 17:16 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (17.60 KB, patch)
2015-06-25 17:24 PDT, Simon Fraser (smfr) 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-06-25 16:02:53 PDT 
[iOS WK2] Swiping back just after scrolling can cause some tiles to disappear
Comment 1 Simon Fraser (smfr) 2015-06-25 16:28:37 PDT 
Created attachment 255592 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-06-25 16:29:19 PDT 
rdar://problem/21233010
Comment 3 Tim Horton 2015-06-25 16:41:18 PDT 
Comment on attachment 255592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255592&action=review

> Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:706
> +void PageClientImpl::beginNavigationGestureInteraction()

Slightly sad that navigationGestureDidBegin/didEnd aren't sufficient, but they're called on the other view I guess? All they do is notify the client, so it seems like you could piggyback on those (and send them to both WebPageProxies, if they're different).

Either way is fine with me.
Comment 4 Simon Fraser (smfr) 2015-06-25 17:03:57 PDT 
Created attachment 255599 [details]
Patch
Comment 5 Simon Fraser (smfr) 2015-06-25 17:16:01 PDT 
Created attachment 255601 [details]
Patch
Comment 6 WebKit Commit Bot 2015-06-25 17:17:41 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 7 Simon Fraser (smfr) 2015-06-25 17:24:33 PDT 
Created attachment 255602 [details]
Patch
Comment 8 Simon Fraser (smfr) 2015-06-25 17:31:07 PDT 
Comment on attachment 255602 [details]
Patch

Tim reviewed this.
Comment 9 Simon Fraser (smfr) 2015-06-25 17:31:16 PDT 
https://trac.webkit.org/r185972