Bug 146322 - Viewport units are wrong when scaled in 2-up mode, cause content to hop around on apple.com/music
Summary: Viewport units are wrong when scaled in 2-up mode, cause content to hop aroun...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-25 13:52 PDT by Tim Horton
Modified: 2015-06-25 15:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.16 KB, patch)
2015-06-25 13:53 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-mavericks (546.27 KB, application/zip)
2015-06-25 14:44 PDT, Build Bot
no flags Details
Patch (5.64 KB, patch)
2015-06-25 14:59 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2015-06-25 13:52:38 PDT
Viewport units are wrong when scaled in 2-up mode, cause content to hop around on apple.com/music
Comment 1 Tim Horton 2015-06-25 13:53:05 PDT
Created attachment 255570 [details]
Patch
Comment 2 Tim Horton 2015-06-25 13:53:25 PDT
<rdar://problem/21413884>
Comment 3 Build Bot 2015-06-25 14:43:56 PDT
Comment on attachment 255570 [details]
Patch

Attachment 255570 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5400530805325824

New failing tests:
fast/fixed-layout/fixed-layout.html
Comment 4 Build Bot 2015-06-25 14:44:00 PDT
Created attachment 255574 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Simon Fraser (smfr) 2015-06-25 14:52:58 PDT
Comment on attachment 255570 [details]
Patch

I think we can layout-test this.
Comment 6 Tim Horton 2015-06-25 14:57:34 PDT
(In reply to comment #5)
> Comment on attachment 255570 [details]
> Patch
> 
> I think we can layout-test this.

It actually is already layout tested, I just have to rebaseline the test.
Comment 7 Tim Horton 2015-06-25 14:59:41 PDT
Created attachment 255576 [details]
Patch
Comment 8 Tim Horton 2015-06-25 15:43:57 PDT
http://trac.webkit.org/changeset/185966