The iOS Speech synthesizer integration should expose the names of the synthesizers <rdar://problem/21538631>
Created attachment 255566 [details] patch
Attachment 255566 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 255566 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=255566&action=review > Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm:240 > // iOS Speech voices only expose their language as an identifying aspect. I feel like this comment just became outdated.
Created attachment 255587 [details] patch
Attachment 255587 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 255588 [details] patch comment removed. thanks
Attachment 255588 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 255590 [details] patch
Comment on attachment 255590 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=255590&action=review > Source/WebCore/platform/ios/PlatformSpeechSynthesizerIOS.mm:240 > + Nit. I don't think you want this blank line here either :)
http://trac.webkit.org/changeset/185997