Bug 146305 - Add command line option and private function to set timeout in jsc command
Summary: Add command line option and private function to set timeout in jsc command
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-24 18:47 PDT by Michael Saboff
Modified: 2015-06-25 11:29 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.31 KB, patch)
2015-06-25 11:25 PDT, Michael Saboff 		fpizlo: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-06-24 18:47:01 PDT 
The jsc command can accept the JSC_timeout environment variable to set a "watch dog" type of timeout.  There should be a way to set this from the command line and for a test to call a function to set this as well.
Comment 1 Michael Saboff 2015-06-24 18:49:17 PDT 
Add a timeout to the test created for https://bugs.webkit.org/show_bug.cgi?id=146298 after this is complete.
Comment 2 Michael Saboff 2015-06-25 11:25:12 PDT 
Created attachment 255564 [details]
Patch
Comment 3 Filip Pizlo 2015-06-25 11:29:18 PDT 
Please hold off on this until you figure out why your test didn't timeout using the existing timeout machinery.
Comment 4 Filip Pizlo 2015-06-25 11:29:56 PDT 
Comment on attachment 255564 [details]
Patch

Lets hold off on this.