Bug 146304 - ExceptionHelpers.cpp::functionCallBase doesn't properly handle embedded comments and string literals
Summary: ExceptionHelpers.cpp::functionCallBase doesn't properly handle embedded comme...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-24 18:33 PDT by Michael Saboff
Modified: 2015-06-25 09:23 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2015-06-24 18:33:55 PDT 
The loop in functionCallBase() tries to match parenthesis.  It tries to recognize multiline comments, but either the comment constructs or parens could actually be inside a string literal and the code doesn't handle those cases.
Comment 1 Michael Saboff 2015-06-25 09:23:37 PDT 
Here are some examples of cases that the function does not properly handle:
    foo.bar("/abc\)*/")
    blah(/* A /* B */ x, y)
    baz("((((")