Bug 146302 – [Win] Update MediaPlayerPrivateAVFoundationCF::supportsType

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Brent Fulgham]

Bring the Windows version of "supportsType" in line with the Mac/iOS version by using AVCFURLAssetIsPlayableExtendedMIMEType.

[Brent Fulgham]

<rdar://problem/19726553>

[Brent Fulgham]

Created attachment 255534 [details]
Patch

[WebKit Commit Bot]

Attachment 255534 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:937:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:983:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

I also fixed a null dereference I ran into while testing.

[Eric Carlson]

Comment on attachment 255534 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255534&action=review

> Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:910
> +static bool isUnsupportedMIMEType(const String& type)

It looks like this and staticMIMETypeList are exactly the same as the ObjC versions. If so, can they be put into the base class and shared?

> Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:1379
> +        if (audibleOptionLocale)
> +            m_languageOfPrimaryAudioTrack = CFLocaleGetIdentifier(audibleOptionLocale.get());
> +        else
> +            m_languageOfPrimaryAudioTrack = emptyString();
> +

You forgot to document this in the ChangeLog.

[Brent Fulgham]

Created attachment 255562 [details]
Patch

[WebKit Commit Bot]

Attachment 255562 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:912:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:1108:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Committed r185958: <http://trac.webkit.org/changeset/185958>