WebViews inside apps built with Address sanitizer will sometimes crash in JSC::MachineThreads::tryCopyOtherThreadStack.
Created attachment 255530 [details]
Comment on attachment 255530 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=255530&action=review
> +// Since we cannot blacklist the system memcpy we must use our own naive implementation,
There is no context here to understand that blackisting is about ASan. Please update the comment to make it clear that this is needed to use ASan with both instrumented and non-instrumented builds.
Created attachment 255563 [details]
Updated comments do note that blacklisting was related to ASan.
Comment on attachment 255563 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=255563&action=review
r=me with a couple of comments.
Change the bug title to reflect the issue.
> +void copyMemory(void*, const void*, size_t);
Don't think this declaration serves much purpose with the definition below.
Created attachment 255565 [details]
Removed the declaration for copyMemory changed the patch name to be more descriptive.
Comment on attachment 255565 [details]
Clearing flags on attachment: 255565
Committed r185957: <http://trac.webkit.org/changeset/185957>
All reviewed patches have been landed. Closing bug.