Bug 146296 - WebContent process is unreponsive/idle when WKWebView is inside a view service.
Summary: WebContent process is unreponsive/idle when WKWebView is inside a view service.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-24 16:23 PDT by Anders Carlsson
Modified: 2015-06-24 16:57 PDT (History)
1 user (show)

See Also:

Attachments
Patch (16.94 KB, patch)
2015-06-24 16:33 PDT, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-06-24 16:23:42 PDT 
WebContent process is unreponsive/idle when WKWebView is inside a view service.
Comment 1 Anders Carlsson 2015-06-24 16:33:58 PDT 
Created attachment 255526 [details]
Patch
Comment 2 WebKit Commit Bot 2015-06-24 16:35:21 PDT 
Attachment 255526 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:76:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:97:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:101:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2015-06-24 16:53:31 PDT 
Comment on attachment 255526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255526&action=review

> Source/WebKit2/UIProcess/ApplicationStateTracker.mm:51
> +    if ([[NSBundle mainBundle].bundleIdentifier isEqualToString:@"com.apple.SafariViewService"])

Please try to find a better less layering-violating way to do this.
Comment 4 Anders Carlsson 2015-06-24 16:57:11 PDT 
Committed r185936: <http://trac.webkit.org/changeset/185936>