Bug 146269 – Add a new color -apple-wireless-playback-target-active

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Said Abou-Hallawa]

Initially it should be just an alias of -apple-system-blue. This will allow us to change the underlying color later.

[Said Abou-Hallawa]

<rdar://problem/21465189>

[Said Abou-Hallawa]

Created attachment 255465 [details]
Patch

[Dean Jackson]

Comment on attachment 255465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255465&action=review

> Source/WebCore/css/CSSParser.cpp:12858
> +    static const LChar* exculde = reinterpret_cast<const LChar*>("-apple-wireless-playback-target-active");
> +    if (hasPrefix(valueKeyword, length, "-apple-system") || WTF::equal(reinterpret_cast<const LChar*>(valueKeyword), exculde, length))

Typo: exclude

> Source/WebCore/platform/spi/cocoa/NSColorSPI.h:37
> ++ (NSColor *)wirelessPlaybackTargetActive;

I don't think this is necessary.

> Source/WebCore/platform/spi/ios/UIColorSPI.h:36
> ++ (UIColor *)wirelessPlaybackTargetActive;

Nor this.

[Said Abou-Hallawa]

Created attachment 255516 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 255516 [details]
Patch

Clearing flags on attachment: 255516

Committed r185934: <http://trac.webkit.org/changeset/185934>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Looks like some bots will need new baselines. At least the windows ones:
https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r185934%20(52608)/fast/css/apple-system-colors-pretty-diff.html

[Chris Dumez]

(In reply to comment #7)
> Looks like some bots will need new baselines. At least the windows ones:
> https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/
> r185934%20(52608)/fast/css/apple-system-colors-pretty-diff.html

<http://trac.webkit.org/changeset/185947>