Bug 146269 - Add a new color -apple-wireless-playback-target-active
Summary: Add a new color -apple-wireless-playback-target-active
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-23 17:58 PDT by Said Abou-Hallawa
Modified: 2015-06-24 22:33 PDT (History)
3 users (show)

See Also:


Attachments
Patch (11.69 KB, patch)
2015-06-23 18:32 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (10.79 KB, patch)
2015-06-24 15:07 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2015-06-23 17:58:12 PDT
Initially it should be just an alias of -apple-system-blue. This will allow us to change the underlying color later.
Comment 1 Said Abou-Hallawa 2015-06-23 17:59:25 PDT
<rdar://problem/21465189>
Comment 2 Said Abou-Hallawa 2015-06-23 18:32:54 PDT
Created attachment 255465 [details]
Patch
Comment 3 Dean Jackson 2015-06-24 12:39:46 PDT
Comment on attachment 255465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255465&action=review

> Source/WebCore/css/CSSParser.cpp:12858
> +    static const LChar* exculde = reinterpret_cast<const LChar*>("-apple-wireless-playback-target-active");
> +    if (hasPrefix(valueKeyword, length, "-apple-system") || WTF::equal(reinterpret_cast<const LChar*>(valueKeyword), exculde, length))

Typo: exclude

> Source/WebCore/platform/spi/cocoa/NSColorSPI.h:37
> ++ (NSColor *)wirelessPlaybackTargetActive;

I don't think this is necessary.

> Source/WebCore/platform/spi/ios/UIColorSPI.h:36
> ++ (UIColor *)wirelessPlaybackTargetActive;

Nor this.
Comment 4 Said Abou-Hallawa 2015-06-24 15:07:34 PDT
Created attachment 255516 [details]
Patch
Comment 5 WebKit Commit Bot 2015-06-24 16:49:01 PDT
Comment on attachment 255516 [details]
Patch

Clearing flags on attachment: 255516

Committed r185934: <http://trac.webkit.org/changeset/185934>
Comment 6 WebKit Commit Bot 2015-06-24 16:49:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2015-06-24 22:25:06 PDT
Looks like some bots will need new baselines. At least the windows ones:
https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r185934%20(52608)/fast/css/apple-system-colors-pretty-diff.html
Comment 8 Chris Dumez 2015-06-24 22:33:24 PDT
(In reply to comment #7)
> Looks like some bots will need new baselines. At least the windows ones:
> https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/
> r185934%20(52608)/fast/css/apple-system-colors-pretty-diff.html

<http://trac.webkit.org/changeset/185947>