Bug 146259 – Add a class that tracks whether we're a background or foreground application

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add a class that tracks whether we're a background or foreground application

[Anders Carlsson]

Created attachment 255448 [details]
Patch

[WebKit Commit Bot]

Attachment 255448 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:51:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:55:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 255448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255448&action=review

> Source/WebKit2/UIProcess/ApplicationStateTracker.h:45
> +    void addListener(id, SEL willEnterForegroundSelector, SEL didEnterBackgroundSelector);

Why not blocks instead of id/SEL?

> Source/WebKit2/UIProcess/ios/WKContentView.mm:213
> +    ApplicationStateTracker::singleton().addListener(self, @selector(_applicationDidEnterBackground), @selector(_applicationWillEnterForeground));

Need WebCore:: here or in a using above.

[Anders Carlsson]

(In reply to comment #3)
> Comment on attachment 255448 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255448&action=review
> 
> > Source/WebKit2/UIProcess/ApplicationStateTracker.h:45
> > +    void addListener(id, SEL willEnterForegroundSelector, SEL didEnterBackgroundSelector);
> 
> Why not blocks instead of id/SEL?

Because I didn't want to have to think about retain cycles and figure out a way to remove the observers. (That's done automatically).

> 
> > Source/WebKit2/UIProcess/ios/WKContentView.mm:213
> > +    ApplicationStateTracker::singleton().addListener(self, @selector(_applicationDidEnterBackground), @selector(_applicationWillEnterForeground));
> 
> Need WebCore:: here or in a using above.

Yes (Well, WebKit::).

[Anders Carlsson]

Committed r185894: <http://trac.webkit.org/changeset/185894>