Bug 146255 - Add operator! and copy/move constructors to WeakObjCPtr
Summary: Add operator! and copy/move constructors to WeakObjCPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-23 15:39 PDT by Anders Carlsson
Modified: 2015-06-23 15:47 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.87 KB, patch)
2015-06-23 15:43 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-06-23 15:39:56 PDT 
Add operator! and copy/move constructors to WeakObjCPtr
Comment 1 Anders Carlsson 2015-06-23 15:43:50 PDT 
Created attachment 255442 [details]
Patch
Comment 2 Andreas Kling 2015-06-23 15:45:29 PDT 
Comment on attachment 255442 [details]
Patch

r=me
Nice test.
Comment 3 WebKit Commit Bot 2015-06-23 15:46:30 PDT 
Attachment 255442 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:40:  objc_copyWeak is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/Shared/mac/WeakObjCPtr.h:41:  objc_moveWeak is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2015-06-23 15:47:41 PDT 
Committed r185887: <http://trac.webkit.org/changeset/185887>