Bug 146253 - MediaSession: Support setting of metadata
Summary: MediaSession: Support setting of metadata
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency tree / graph
 
Reported: 2015-06-23 15:31 PDT by Matt Rajca
Modified: 2015-06-24 09:40 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.56 KB, patch)
2015-06-23 18:25 PDT, Matt Rajca 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-06-23 15:31:20 PDT 
The MediaSession.setMetadata method needs to be implemented as described in section 5.1.3 of the Media Session spec.
Comment 1 Radar WebKit Bug Importer 2015-06-23 15:32:18 PDT 
<rdar://problem/21512861>
Comment 2 Matt Rajca 2015-06-23 18:25:49 PDT 
Created attachment 255464 [details]
Patch
Comment 3 Eric Carlson 2015-06-24 08:34:49 PDT 
Comment on attachment 255464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255464&action=review

> Source/WebCore/Modules/mediasession/MediaSession.cpp:39
> +    : m_scriptExecutionContext(&context)

Unless you will need the ScriptExecutionContext for something else later, I think we should capture a reference to the document instead as the only thing we do with the ScriptExecutionContext is get its document.
Comment 4 Matt Rajca 2015-06-24 09:40:31 PDT 
Committed r185914: <http://trac.webkit.org/changeset/185914>
Comment 5 Matt Rajca 2015-06-24 09:40:57 PDT 
(In reply to comment #3)
> Comment on attachment 255464 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255464&action=review
> 
> > Source/WebCore/Modules/mediasession/MediaSession.cpp:39
> > +    : m_scriptExecutionContext(&context)
> 
> Unless you will need the ScriptExecutionContext for something else later, I
> think we should capture a reference to the document instead as the only
> thing we do with the ScriptExecutionContext is get its document.

Changed. Thanks!