Bug 146252 – Should reduce tile coverage for the first paint after a tab switch

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Andreas Kling]

<rdar://problem/19821583>

[Andreas Kling]

Created attachment 255441 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 255441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255441&action=review

> Source/WebCore/page/FrameView.cpp:2496
> +    // Turn off speculative tiling for a brief moment after a FrameView appears on screen.
> +    // Note that adjustTiledBackingCoverage() kicks the (500ms) timer to re-enable it.
> +    m_speculativeTilingEnabled = false;
> +    m_wasScrolledByUser = false;
> +    adjustTiledBackingCoverage();

Do you want to do this for non-main FrameViews?

[Andreas Kling]

(In reply to comment #2)
> Comment on attachment 255441 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255441&action=review
> 
> > Source/WebCore/page/FrameView.cpp:2496
> > +    // Turn off speculative tiling for a brief moment after a FrameView appears on screen.
> > +    // Note that adjustTiledBackingCoverage() kicks the (500ms) timer to re-enable it.
> > +    m_speculativeTilingEnabled = false;
> > +    m_wasScrolledByUser = false;
> > +    adjustTiledBackingCoverage();
> 
> Do you want to do this for non-main FrameViews?

Ah, good point. We shouldn't do this for non-main FrameViews.

[Andreas Kling]

Created attachment 255445 [details]
Patch

Only do this for the main FrameView.

[WebKit Commit Bot]

Comment on attachment 255445 [details]
Patch

Clearing flags on attachment: 255445

Committed r185897: <http://trac.webkit.org/changeset/185897>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.