RESOLVED FIXED 146234
[GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
https://bugs.webkit.org/show_bug.cgi?id=146234
Summary [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exceptio...
Carlos Garcia Campos
Reported 2015-06-23 04:13:21 PDT
This is because we don't provide any quota, and 0 is used by default, so there's never enough quota and openDatabase fails.
Attachments
Patch (5.81 KB, patch)
2015-06-23 04:18 PDT, Carlos Garcia Campos
no flags
Patch (7.60 KB, patch)
2015-07-02 00:17 PDT, Carlos Garcia Campos
svillar: review+
Carlos Garcia Campos
Comment 1 2015-06-23 04:18:10 PDT
WebKit Commit Bot
Comment 2 2015-06-23 04:19:17 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2015-06-23 04:19:29 PDT
Attachment 255405 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:149: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 4 2015-07-02 00:17:43 PDT
Created attachment 255997 [details] Patch Rebased to current trunk and also enables the WebSQL directory unit test that is currently disabled because of this bug.
WebKit Commit Bot
Comment 5 2015-07-02 00:20:33 PDT
Attachment 255997 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:149: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 6 2015-07-02 00:25:50 PDT
EWS failure is not because of this patch, but the internal jhbuild doing too much stuff for every patch and sometimes failing to do so.
Sergio Villar Senin
Comment 7 2015-07-02 03:10:03 PDT
Comment on attachment 255997 [details] Patch So aren't we running WebSQL layout tests?
Carlos Garcia Campos
Comment 8 2015-07-02 03:27:47 PDT
(In reply to comment #7) > Comment on attachment 255997 [details] > Patch > > So aren't we running WebSQL layout tests? WTR implements this callback, returning also 5MB.
Sergio Villar Senin
Comment 9 2015-07-02 03:58:46 PDT
(In reply to comment #8) > (In reply to comment #7) > > Comment on attachment 255997 [details] > > Patch > > > > So aren't we running WebSQL layout tests? > > WTR implements this callback, returning also 5MB. My point was, we either run them and all of them were failing, or we are skipping them and you aren't unskipping them.
Carlos Garcia Campos
Comment 10 2015-07-02 04:49:43 PDT
(In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > Comment on attachment 255997 [details] > > > Patch > > > > > > So aren't we running WebSQL layout tests? > > > > WTR implements this callback, returning also 5MB. > > My point was, we either run them and all of them were failing, or we are > skipping them and you aren't unskipping them. We run them and they don't fail because WTR implements that callback in its UI client.
Carlos Garcia Campos
Comment 11 2015-07-02 06:01:43 PDT
Note You need to log in before you can comment on or make changes to this bug.