Bug 146231 - [CSS Grid Layout] Performance optimization: avoid computing overflow alignment if not needed
Summary: [CSS Grid Layout] Performance optimization: avoid computing overflow alignmen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-23 01:55 PDT by Javier Fernandez
Modified: 2015-06-23 07:19 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.48 KB, patch)
2015-06-23 03:44 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Patch (4.49 KB, patch)
2015-06-23 06:21 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2015-06-23 01:55:58 PDT
We we compute grid item's position, both along column and row axis, we compute overflow even if alignment value is 'start' and there is no need of applying any overflow handling, given that there is no risk of data loss.

Computing overflow adds an unnecessary overhead, so we should remove it to improve performance.
Comment 1 Javier Fernandez 2015-06-23 03:44:11 PDT
Created attachment 255404 [details]
Patch
Comment 2 Sergio Villar Senin 2015-06-23 06:14:35 PDT
Comment on attachment 255404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255404&action=review

Yay!

> Source/WebCore/ChangeLog:11
> +        This patch avoid, computing the overflow in all the cases, since it adds an unneeded

"This patch avoids computing"
Comment 3 Javier Fernandez 2015-06-23 06:21:23 PDT
Created attachment 255408 [details]
Patch
Comment 4 WebKit Commit Bot 2015-06-23 07:18:59 PDT
Comment on attachment 255408 [details]
Patch

Clearing flags on attachment: 255408

Committed r185874: <http://trac.webkit.org/changeset/185874>
Comment 5 WebKit Commit Bot 2015-06-23 07:19:02 PDT
All reviewed patches have been landed.  Closing bug.